-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CoreOS-enabled option for Satellite location create #3914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let me know how you'd like to handle the test - I updated it to check if coreos_enabled is true. However, I can revert or create a new test case that tests coreos separately. |
hkantare
reviewed
Jul 12, 2022
hkantare
reviewed
Jul 14, 2022
SunithaGudisagarIBM
pushed a commit
to ibm-vpc/terraform-provider-ibm
that referenced
this pull request
Sep 14, 2022
* initial changes to accept coreos locations * fixed reference to variable * added doc for new variable * update to use the latest version of satellite SDK * updated test to check for coreosenabled * added computed field and added to Read * add coreos enabled arguments to data source * remove optional as data source is only computed * add core_enabled attribute to data source docs Co-authored-by: bhpratt <bhpratt@ncsu.edu>
SunithaGudisagarIBM
pushed a commit
to ibm-vpc/terraform-provider-ibm
that referenced
this pull request
Sep 14, 2022
* initial changes to accept coreos locations * fixed reference to variable * added doc for new variable * update to use the latest version of satellite SDK * updated test to check for coreosenabled * added computed field and added to Read * add coreos enabled arguments to data source * remove optional as data source is only computed * add core_enabled attribute to data source docs Co-authored-by: bhpratt <bhpratt@ncsu.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates #3838
Output from acceptance testing:
Note, does require updating container services SDK to latest:
github.com/IBM-Cloud/container-services-go-sdk v0.0.0-20220622142911-811d18c8c775
to pick up SDK updates.Related SDK PRs:
IBM-Cloud/container-services-go-sdk#4 (comment)
https://github.com/IBM-Cloud/container-services-go-sdk/pull/5/files